fix: field selection set final values#1212
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
We have the concept of "leaf fields" and "leaf values" already (though it is introduced later in the spec), maybe we should reference that here instead. One concern at the moment is the current wording doesn't handle lists of scalars/enums (or lists of those lists!).
It's still better than what we currently have though; thanks for the contribution!
benjie
added
✏️ Editorial
Co-authored-by: Benjie <benjie@jemjie.com>
|
I've pre-emptively added this to the April wg: graphql/graphql-wg#1947 |
|
Sorry, I forgot formatting. Now tests should pass. |
|
Thanks! For the record, I'm not sure this requires a working group item, I'm fine to merge this async. I mostly added it as a forcing function to review this PR if we haven't acted by then. |
4 participants
AFAIK scalar and enum values are considered to be distinct throughout the specification so I think this would be more correct description of field selection.
I didn't change the sentence below the modified one because it doesn't contain any enum values, but I may add some if that'd be beneficial.
It really is a nitpick, but I stopped on it while reading the spec.